Browser Plugin: Implement CanGoBack/CanGoForward

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/string_util.h"
 #include "content/browser/browser_plugin/browser_plugin_guest_helper.h"
@@ skipping 364 matching lines @@
       new BrowserPluginMsg_LoadRedirect(
           instance_id(), old_url, new_url, is_top_level));
 }
 
 void BrowserPluginGuest::DidCommitProvisionalLoadForFrame(
     int64 frame_id,
     bool is_main_frame,
     const GURL& url,
     PageTransition transition_type,
     RenderViewHost* render_view_host) {
+  SendMessageToEmbedder(
+      new BrowserPluginMsg_NavigationStateUpdate(
+          instance_id(),
+          web_contents()->GetController().GetCurrentEntryIndex(),
+          web_contents()->GetController().GetEntryCount()));

[Charlie Reis, 2012/10/10 06:06:53]

I think we should combine these two IPC messages into one.  (It should be sent
on all navigations, and is_main_frame should just be a parameter.)  Note that
Robert has a CL in progress for sending is_main_frame as a parameter here:
https://codereview.chromium.org/11035067/

Also, I'm 90% sure that commits are the only way that index and count will
change, but if I'm forgetting something, then the app will be confused about
when it can go back and forward.  (Things like prerendering, instant, session
restore, pushState, and others have all surprised me in the past.)

[Fady Samuel, 2012/10/10 17:36:44]

Done.

   // Inform its embedder of the updated URL.
   if (is_main_frame) {
     SendMessageToEmbedder(
         new BrowserPluginMsg_DidNavigate(
             instance_id(),
             url,
             render_view_host->GetProcess()->GetID()));
     RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
   }
 }
@@ skipping 27 matching lines @@
       break;
   }
 }
 
 void BrowserPluginGuest::SendMessageToEmbedder(IPC::Message* msg) {
   DCHECK(embedder_render_process_host());
   embedder_render_process_host()->Send(msg);
 }
 
 }  // namespace content