Issue 11092003: Implement part-of directive.

Issue 11092003: Implement part-of directive. (Closed)

Created:
8 years, 2 months ago by ahe

Modified:
8 years, 2 months ago

Reviewers:
Johnni Winther, karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement part-of directive. Committed: https://code.google.com/p/dart/source/detail?r=13398

Patch Set 2 : Update co19 status for dart2dart #

Total comments: 5

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+273 lines, -73 lines)			Patch
M	dart/lib/compiler/implementation/dart2js.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/elements/elements.dart	View		3 chunks	+40 lines, -0 lines	2 comments	Download
M	dart/lib/compiler/implementation/scanner/listener.dart	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	dart/lib/compiler/implementation/scanner/scanner_task.dart	View		3 chunks	+25 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/scannerlib.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/tree/nodes.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/lib/compiler/implementation/util/util.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/lib/compiler/implementation/warnings.dart	View		1 chunk	+15 lines, -0 lines	3 comments	Download
M	dart/tests/co19/co19-compiler.status	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/co19/co19-dart2dart.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View		7 chunks	+71 lines, -57 lines	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	dart/tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	dart/tests/language/part2_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	dart/tests/language/part_part.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	dart/tests/language/part_test.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
A	dart/tests/utils/recursive_import_test.dart	View		1 chunk	+88 lines, -0 lines	0 comments	Download
M	dart/tests/utils/utils.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/11092003/diff/8003/dart/lib/compiler/implementation/elements/elements.dart File dart/lib/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/11092003/diff/8003/dart/lib/compiler/implementation/elements/elements.dart#newcode544 dart/lib/compiler/implementation/elements/elements.dart:544: if (libraryTag != null) { Isn't it also ...

8 years, 2 months ago (2012-10-09 07:43:36 UTC) #2

ahe

Thank you, Johnni! https://codereview.chromium.org/11092003/diff/8003/dart/lib/compiler/implementation/elements/elements.dart File dart/lib/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/11092003/diff/8003/dart/lib/compiler/implementation/elements/elements.dart#newcode544 dart/lib/compiler/implementation/elements/elements.dart:544: if (libraryTag != null) { On ...

8 years, 2 months ago (2012-10-09 07:48:09 UTC) #3

karlklose

8 years, 2 months ago (2012-10-09 07:49:47 UTC) #4

https://codereview.chromium.org/11092003/diff/8003/dart/lib/compiler/implemen...
File dart/lib/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/11092003/diff/8003/dart/lib/compiler/implemen...
dart/lib/compiler/implementation/warnings.dart:263: 'Error: part header must
come before top-level definitions.');
See also http://code.google.com/p/dart/issues/detail?id=5177

Expand Messages | Collapse Messages