media: Add extra logging in AudioClock.

media: Add extra logging in AudioClock.

This would help investigate a crash due to DCHECK.

BUG=481640
TEST=none
R=dalecurtis@chromium.org

Committed: https://crrev.com/fd6f83cc6a4201f889fa83d9857142c3ca8089e4
Cr-Commit-Position: refs/heads/master@{#327381}

[DaleCurtis, 2015-04-28 18:28:12]

https://codereview.chromium.org/1109183002/diff/1/media/filters/audio_clock.cc
File media/filters/audio_clock.cc (right):

https://codereview.chromium.org/1109183002/diff/1/media/filters/audio_clock.c...
media/filters/audio_clock.cc:84: DCHECK(timestamp >= front_timestamp_) << ": "
<< timestamp << ", "
I think you can just use DCHECK_GE() now?

[xhwang, 2015-04-28 19:50:54]

comments addressed

[xhwang, 2015-04-28 19:51:14]

https://codereview.chromium.org/1109183002/diff/1/media/filters/audio_clock.cc
File media/filters/audio_clock.cc (right):

https://codereview.chromium.org/1109183002/diff/1/media/filters/audio_clock.c...
media/filters/audio_clock.cc:84: DCHECK(timestamp >= front_timestamp_) << ": "
<< timestamp << ", "
On 2015/04/28 18:28:12, DaleCurtis wrote:
> I think you can just use DCHECK_GE() now?

Done.

[DaleCurtis, 2015-04-28 20:11:59]

The DCHECK should print the values itself, no?

[xhwang, 2015-04-28 20:50:42]

comments addressed

[DaleCurtis, 2015-04-28 20:51:22]

lgtm, we should probably scrub media for all forms of this now that timedelta
supports comparisons.

[xhwang, 2015-04-28 20:52:01]

On 2015/04/28 20:11:59, DaleCurtis wrote:
> The DCHECK should print the values itself, no?

You are right! Sorry for my dumbness. Updated...

[xhwang, 2015-04-28 20:53:14]

On 2015/04/28 20:51:22, DaleCurtis wrote:
> lgtm, we should probably scrub media for all forms of this now that timedelta
> supports comparisons.

Yes, it also supports << directly. I remember we had places where we do

<< t.InMilliSeconds() << " ms".

[xhwang, 2015-04-28 20:53:19]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2015-04-28 20:54:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1109183002/40001

[commit-bot: I haz the power, 2015-04-28 22:43:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-28 22:44:06]

Patchset 3 (id:??) landed as
https://crrev.com/fd6f83cc6a4201f889fa83d9857142c3ca8089e4
Cr-Commit-Position: refs/heads/master@{#327381}