Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1109163004: Prep for update to latest QEMU version (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Prep for update to latest QEMU version Remove dependency of checked-in qemu tarball. Instead download tarball on demand and verify with SHA1 sum. Once this lands there is a corresponding change to the third_party repository needed before we can update to 2.3.0: https://codereview.chromium.org/1105003003/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=4157 R=bradnelson@google.com Committed: https://chromium.googlesource.com/native_client/src/native_client/+/91f01b73180d713eca02648414b333922c01e5cd

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -20 lines) Patch
M tools/trusted_cross_toolchains/qemu_tool_arm.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/trusted_cross_toolchains/qemu_tool_mips32.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.precise.sh View 2 chunks +23 lines, -8 lines 0 comments Download
M tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh View 3 chunks +25 lines, -10 lines 3 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
5 years, 7 months ago (2015-04-28 20:39:49 UTC) #2
bradn
lgtm https://codereview.chromium.org/1109163004/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh File tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh (right): https://codereview.chromium.org/1109163004/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh#newcode431 tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh:431: wget -O ${TMP}/${QEMU_TARBALL} $QEMU_URL curl?
5 years, 7 months ago (2015-04-28 20:46:16 UTC) #4
Sam Clegg
https://codereview.chromium.org/1109163004/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh File tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh (right): https://codereview.chromium.org/1109163004/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh#newcode431 tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh:431: wget -O ${TMP}/${QEMU_TARBALL} $QEMU_URL On 2015/04/28 20:46:16, bradn wrote: ...
5 years, 7 months ago (2015-04-28 21:08:32 UTC) #5
bradn
https://codereview.chromium.org/1109163004/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh File tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh (right): https://codereview.chromium.org/1109163004/diff/1/tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh#newcode431 tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh:431: wget -O ${TMP}/${QEMU_TARBALL} $QEMU_URL On 2015/04/28 20:46:16, bradn wrote: ...
5 years, 7 months ago (2015-04-28 21:11:08 UTC) #6
Sam Clegg
5 years, 7 months ago (2015-04-28 21:20:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91f01b73180d713eca02648414b333922c01e5cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698