Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1109153004: Initial CL to create GrBatchTest infrastructure (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@rand-batch0
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initial CL to create GrBatchTest infrastructure BUG=skia: Committed: https://skia.googlesource.com/skia/+/3f655f34a234aceaa0c2947ce999a2127c729dea

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : adding strokerect #

Patch Set 4 : adding stroke rect #

Total comments: 1

Patch Set 5 : rebase onto master #

Total comments: 1

Patch Set 6 : rebase #

Patch Set 7 : feedback inc #

Patch Set 8 : adding flags #

Patch Set 9 : tweaks #

Patch Set 10 : tweaks #

Patch Set 11 : windows warnings #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -25 lines) Patch
M gyp/gpu.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkPostConfig.h View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M include/gpu/GrTestUtils.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +14 lines, -6 lines 0 comments Download
M src/gpu/GrAARectRenderer.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 3 4 5 6 7 5 chunks +80 lines, -17 lines 0 comments Download
A src/gpu/GrBatchTest.h View 1 2 3 4 5 6 7 8 9 1 chunk +37 lines, -0 lines 0 comments Download
A src/gpu/GrBatchTest.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +27 lines, -0 lines 0 comments Download
M src/gpu/GrTestUtils.cpp View 1 2 3 4 5 6 7 2 chunks +19 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
joshualitt
ptal
5 years, 7 months ago (2015-04-28 20:21:46 UTC) #2
joshualitt
On 2015/04/28 20:21:46, joshualitt wrote: > ptal adding stroke rect
5 years, 7 months ago (2015-04-28 20:59:25 UTC) #3
joshualitt
adding Robert for stroke rect stuff
5 years, 7 months ago (2015-04-29 13:00:17 UTC) #5
robertphillips
lgtm but I would like Brian to also have a look https://codereview.chromium.org/1109153004/diff/60001/src/gpu/GrTestUtils.cpp File src/gpu/GrTestUtils.cpp (right): ...
5 years, 7 months ago (2015-04-29 13:23:01 UTC) #6
bsalomon
lgtm but I think we should probably have our own test macro rather than piggy ...
5 years, 7 months ago (2015-04-29 16:03:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109153004/200001
5 years, 7 months ago (2015-04-29 16:56:00 UTC) #10
commit-bot: I haz the power
Committed patchset #11 (id:200001) as https://skia.googlesource.com/skia/+/3f655f34a234aceaa0c2947ce999a2127c729dea
5 years, 7 months ago (2015-04-29 17:01:27 UTC) #11
brucedawson
5 years, 7 months ago (2015-04-30 20:19:35 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1109153004/diff/200001/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/1109153004/diff/200001/src/gpu/GrTestUtils.cp...
src/gpu/GrTestUtils.cpp:33: static SkRect gRects[1];
Why is this array declared as having just one element when seven elements are
referenced down below? This triggers a series of /analyze warnings, including
this one:

src\third_party\skia\src\gpu\grtestutils.cpp(67) : warning C6201: Index '6' is
out of valid index range '0' to '0' for possibly stack allocated buffer 'struct
SkRect * `struct SkRect const & __cdecl GrTest::TestRect(class SkRandom
*)'::`2'::gRects'.

Powered by Google App Engine
This is Rietveld 408576698