Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1109153002: Fix stale pointer issue in heap snapshot generator (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow
Modified:
5 years, 7 months ago
Reviewers:
Yang, loislo
CC:
v8-dev, yurys
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix stale pointer issue in heap snapshot generator Committed: https://crrev.com/fefe91ce6a49b644e909faa92bee10814eaed729 Cr-Commit-Position: refs/heads/master@{#28124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/heap-snapshot-generator.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
PTAL. Regression test: failing try jobs on https://codereview.chromium.org/1097113003/
5 years, 7 months ago (2015-04-28 16:46:09 UTC) #2
Yang
LGTM. Adding Yury and Ilya on CC.
5 years, 7 months ago (2015-04-29 08:02:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109153002/1
5 years, 7 months ago (2015-04-29 08:39:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 09:03:11 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fefe91ce6a49b644e909faa92bee10814eaed729 Cr-Commit-Position: refs/heads/master@{#28124}
5 years, 7 months ago (2015-04-29 09:03:23 UTC) #7
loislo
5 years, 7 months ago (2015-04-29 09:19:54 UTC) #8
Message was sent while issue was closed. 
On 2015/04/29 09:03:23, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/fefe91ce6a49b644e909faa92bee10814eaed729
> Cr-Commit-Position: refs/heads/master@{#28124}

lgtm

Powered by Google App Engine
This is Rietveld 408576698