Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1109133002: Print PID and isolate address in gc traces. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Print PID and isolate address in gc traces. Note, that it also moves incremental marking traces behind the --trace-incremental-marking flag. Other PrintF's of the GC should be moved as well to PrintPIDAndIsolate. BUG= Committed: https://crrev.com/ba55965125d1e9aa5b6dbfff6d854b530fce0559 Cr-Commit-Position: refs/heads/master@{#28135}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -96 lines) Patch
M src/heap/gc-tracer.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 6 chunks +71 lines, -67 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -13 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 5 chunks +33 lines, -12 lines 0 comments Download
M src/heap/incremental-marking-inl.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/utils.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/utils.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Hannes Payer (out of office)
5 years, 7 months ago (2015-04-28 12:39:30 UTC) #2
ulan
lgtm Maybe shorten the function name, e.g. PrintIsolate, PrintHeap, PrintI, or PrintH? :)
5 years, 7 months ago (2015-04-28 12:44:49 UTC) #3
Erik Corry
lgtm
5 years, 7 months ago (2015-04-28 14:07:15 UTC) #5
Hannes Payer (out of office)
PrintIsolate it is. Done.
5 years, 7 months ago (2015-04-29 11:53:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109133002/20001
5 years, 7 months ago (2015-04-29 11:53:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/5294)
5 years, 7 months ago (2015-04-29 11:57:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109133002/40001
5 years, 7 months ago (2015-04-29 13:50:27 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-29 14:29:45 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 14:30:03 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ba55965125d1e9aa5b6dbfff6d854b530fce0559
Cr-Commit-Position: refs/heads/master@{#28135}

Powered by Google App Engine
This is Rietveld 408576698