ChromeOS: properly enable multiprofile mode in LoginManagerTest.

ChromeOS: properly enable multiprofile mode in LoginManagerTest.

Fix some tests that fail when it is enabled.

BUG=326832
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242068

[mattm, 2013-12-17 23:42:34]

I needed to make a multiprofile test, so I fixed this.

Re: point #2 in the bug, changing the LoginManagerTest constructor's
should_launch_browser to true fixes the issue with using the wrong profile path,
though I didn't really dig into whether this makes sense.

[xiyuan, 2013-12-18 23:47:03]

LGTM 

Please wait for dzhioev@'s review as well. Thanks.

[dzhioev (left Google), 2013-12-19 01:17:09]

On 2013/12/17 23:42:34, mattm wrote:
> I needed to make a multiprofile test, so I fixed this.
> 
> Re: point #2 in the bug, changing the LoginManagerTest constructor's
> should_launch_browser to true fixes the issue with using the wrong profile
path,
> though I didn't really dig into whether this makes sense.
Sorry for a long delay.

It makes sense because with changing |should_launch_browser| you change the way
how testing profile is created in FakeLoginUtils
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...
.
It looks like something doesn't work with TestingProfile in multi-profile mode.
Could you please instead of changing |should_launch_browser| 
change FakeLoginUtils::PrepareProfile to always use profiles created by 
CreateProfile? Just replace 'if' construction pointed above with
Profile* profile = CreateProfile(user_context.username). I think that should
work.
LGTM after that. I'll investigate later whats happening with TestingProfile.

[mattm, 2013-12-19 23:42:17]

Thanks, done.

[commit-bot: I haz the power, 2013-12-19 23:44:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/110913009/40001

[commit-bot: I haz the power, 2013-12-20 01:08:27]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-20 01:41:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/110913009/40001

[commit-bot: I haz the power, 2013-12-20 10:20:14]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 10:37:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/110913009/40001

[commit-bot: I haz the power, 2013-12-20 12:16:17]

Change committed as 242068