Issue 110913005: Revert of Blend background with existing content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110913005: Revert of Blend background with existing content (Closed)

Created:
7 years ago by johnme

Modified:
7 years ago

Reviewers:
jamesr, aelias_OOO_until_Jul13, boliu, enne (OOO)

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, trchen

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Revert of https://codereview.chromium.org/23483051/ Reason for revert: WebViewTest.SetBaseBackgroundColorAndBlendWithExistingContent is failing consistently on WebKit Android (Nexus4) and Android Tests (dbg) as WebCore::redChannel(color) evaluates to false TBR=aelias@chromium.org,enne@chromium.org,jamesr@chromium.org,boliu@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163699

Created: 7 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -58 lines)			Patch
M	Source/core/page/Settings.in	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderBoxModelObject.cpp	View	1 chunk	+18 lines, -17 lines	0 comments	Download
M	Source/web/WebSettingsImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/web/tests/WebViewTest.cpp	View	2 chunks	+0 lines, -33 lines	0 comments	Download
M	public/web/WebSettings.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/110913005/1

7 years ago (2013-12-11 11:26:29 UTC) #2

Message was sent while issue was closed.

Change committed as 163699