Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/ddbg.dart

Issue 110913002: Transmit breakpoint id on paused event (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_api_impl_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ddbg.dart
===================================================================
--- tools/ddbg.dart (revision 31028)
+++ tools/ddbg.dart (working copy)
@@ -47,7 +47,6 @@
int seqNum = 0;
bool isDebugging = false;
-bool stepMode = false;
Process targetProcess = null;
bool suppressNextExitCode = false;
@@ -511,7 +510,6 @@
}
void processCommand(String cmdLine) {
-
void huh() {
print("'$cmdLine' not understood, try 'help' for help.");
}
@@ -529,8 +527,6 @@
{ 'r':'resume', 's':'stepOver', 'si':'stepInto', 'so':'stepOut'};
if (resume_commands[command] != null) {
if (!checkPaused()) return;
- // TODO(turnidge): step mode isn't quite right yet.
- stepMode = (command != 'r');
var cmd = { "id": seqNum,
"command": resume_commands[command],
"params": { "isolateId" : currentIsolate.id } };
@@ -1033,9 +1029,10 @@
assert(location != null);
isolate.pausedLocation = location;
if (reason == "breakpoint") {
- return printLocation((stepMode ? null : "Breakpoint"), location);
+ var bpId = (msg["params"]["breakpointId"]);
+ var label = (bpId != null) ? "Breakpoint $bpId" : null;
+ return printLocation(label, location);
} else if (reason == "interrupted") {
- stepMode = false;
return printLocation("Interrupted", location);
} else {
assert(reason == "exception");
@@ -1140,7 +1137,7 @@
}
if (i >= vmData.length) {
return false;
- } else {
+ } else {
return char != "{";
}
}
@@ -1328,7 +1325,6 @@
print('Timed out waiting for debugger to start.\nError: $e');
return closeVmSocket();
}
-
// Wait and retry.
return new Future.delayed(delay, () {
openVmSocket(attempt + 1);
@@ -1361,7 +1357,6 @@
vmSubscription = null;
vmSock = null;
outstandingCommands = null;
-
return Future.wait(cleanupFutures);
}
« no previous file with comments | « runtime/vm/debugger_api_impl_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698