Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: runtime/vm/debugger.h

Issue 110913002: Transmit breakpoint id on paused event (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/include/dart_debugger_api.h ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.h
===================================================================
--- runtime/vm/debugger.h (revision 31028)
+++ runtime/vm/debugger.h (working copy)
@@ -254,13 +254,22 @@
kIsolateInterrupted = 6,
};
struct DebuggerEvent {
+ explicit DebuggerEvent(EventType event_type)
+ : type(event_type) {
+ top_frame = NULL;
+ breakpoint = NULL;
+ exception = NULL;
+ isolate_id = 0;
+ }
EventType type;
- union {
- ActivationFrame* top_frame;
- SourceBreakpoint* breakpoint;
- const Object* exception;
- Dart_Port isolate_id;
- };
+ // type == kBreakpointReached.
+ ActivationFrame* top_frame;
+ // type == kBreakpointResolved, kBreakpointReached.
+ SourceBreakpoint* breakpoint;
+ // type == kExceptionThrown.
+ const Object* exception;
+ // type == kIsolate(Created|Shutdown|Interrupted).
+ Dart_Port isolate_id;
};
typedef void EventHandler(DebuggerEvent *event);
@@ -391,7 +400,8 @@
const Code& code);
static DebuggerStackTrace* CollectStackTraceNew();
void SignalBpResolved(SourceBreakpoint *bpt);
- void SignalPausedEvent(ActivationFrame* top_frame);
+ void SignalPausedEvent(ActivationFrame* top_frame,
+ SourceBreakpoint* bpt);
intptr_t nextId() { return next_id_++; }
« no previous file with comments | « runtime/include/dart_debugger_api.h ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698