Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: tools/testing/dart/co19_test.dart

Issue 11091070: Change Process.start to return a future that completes with a (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Restructure to get rid of _onStart and _onError Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/process_working_directory_test.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/co19_test.dart
diff --git a/tools/testing/dart/co19_test.dart b/tools/testing/dart/co19_test.dart
index 70495fb731e0f3a8c33869fca5401f968b14865c..39a12242712aabe8261313644e7f3831ac0897fd 100644
--- a/tools/testing/dart/co19_test.dart
+++ b/tools/testing/dart/co19_test.dart
@@ -59,11 +59,8 @@ void main() {
var listTests = firstConfiguration['list'];
var configurationIterator = configurations.iterator();
- bool enqueueConfiguration(ProcessQueue queue) {
- if (!configurationIterator.hasNext()) {
- return false;
- }
-
+ void enqueueConfiguration(ProcessQueue queue) {
+ if (!configurationIterator.hasNext()) return;
var configuration = configurationIterator.next();
for (String selector in selectors.getKeys()) {
if (selector == 'co19') {
@@ -72,7 +69,6 @@ void main() {
throw 'Error: unexpected selector: "$selector".';
}
}
- return true;
}
// Start process queue.
« no previous file with comments | « tests/standalone/io/process_working_directory_test.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698