Issue 11091058: Reland r161256: Fix the crash that was happening on the buildbot (but not trybots, for a strange re…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11091058: Reland r161256: Fix the crash that was happening on the buildbot (but not trybots, for a strange re… (Closed)

Created:
8 years, 2 months ago by jam

Modified:
8 years, 2 months ago

Reviewers:
scottmg

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Reland r161256: Fix the crash that was happening on the buildbot (but not trybots, for a strange reason) because ResourceBundle was initialized twice for tests that use the RenderViewTest harness. The one difference is to check if ResourceBundle is initialized before initializing it. This is needed because on content_browsertests it's not initialized while in browser_tests it is. We can't make the two browser test binaries behave the same because of differences in how chrome's browser_tests and unit_tests can share the same test suite while in content that's not possible. TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161361

Patch Set 1 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -14 lines)			Patch
M	content/public/test/render_view_test.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin_browsertest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/renderer/render_view_browsertest.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/renderer/render_view_browsertest_mac.mm	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/renderer/render_widget_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/renderer_accessibility_browsertest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/test/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/test/content_test_suite.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages