Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 11091029: Fix for issue 5744: also register parameter types for closure invocations to the backend. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/call_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
===================================================================
--- lib/compiler/implementation/ssa/codegen.dart (revision 13418)
+++ lib/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1549,6 +1549,11 @@
node);
Selector call = new Selector.callClosureFrom(node.selector);
world.registerDynamicInvocation(call.name, call);
+ // A closure can also be invoked through [HInvokeDynamicMethod] by
+ // explicitly calling the [:call:] method. Therefore, we must also
+ // register types here to let the backend invalidate wrong
+ // optimizations.
+ backend.registerDynamicInvocation(node, call, types);
floitsch 2012/10/10 08:56:33 FYI: this doesn't pass in checked mode: registerDy
ngeoffray 2012/10/10 09:35:30 Good catch. I probably won't have time to run all
}
visitInvokeStatic(HInvokeStatic node) {
« no previous file with comments | « no previous file | tests/language/call_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698