Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: pkg/intl/lib/date_format.dart

Issue 11091012: Clean up TODOs and comments in Intl (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/intl/lib/intl.dart » ('j') | pkg/intl/lib/intl.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/date_format.dart
===================================================================
--- pkg/intl/lib/date_format.dart (revision 13364)
+++ pkg/intl/lib/date_format.dart (working copy)
@@ -184,8 +184,6 @@
// the constructor seems awkward, especially with the possibility of
// confusion with the locale. A "fluent" interface with cascading on an
// instance might work better? A list of patterns is also possible.
- // TODO(alanknight): There will need to be at least setup type async
- // operations to avoid the need to bring along every locale in every program
_locale = Intl.verifiedLocale(locale);
addPattern(newPattern);
}
@@ -522,7 +520,6 @@
return dateTimeSymbols.containsKey(localeName);
}
- // TODO(alanknight): This can be a variable once that's permitted.
static List get _fieldConstructors => [
(pattern, parent) => new _DateFormatQuotedField(pattern, parent),
(pattern, parent) => new _DateFormatPatternField(pattern, parent),
« no previous file with comments | « no previous file | pkg/intl/lib/intl.dart » ('j') | pkg/intl/lib/intl.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698