src/messages.js - Issue 1109093002: Reland: Preprocess structured stack trace on GC to get rid of code reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.js

Issue 1109093002: Reland: Preprocess structured stack trace on GC to get rid of code reference. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.js

diff --git a/src/messages.js b/src/messages.js

index eadc880715a01d60bd93e394632a3cd2cdcacbd5..dd51e0b4c92fc0edbe9c4b2f4c7faca4f95b6df3 100644

--- a/src/messages.js

+++ b/src/messages.js

@@ -1009,7 +1009,7 @@ function GetStackFrames(raw_stack) {

var fun = raw_stack[i + 1];

var code = raw_stack[i + 2];

var pc = raw_stack[i + 3];

- var pos = %FunctionGetPositionForOffset(code, pc);

+ var pos = %_IsSmi(code) ? code : %FunctionGetPositionForOffset(code, pc);

sloppy_frames--;

frames.push(new CallSite(recv, fun, pos, (sloppy_frames < 0)));

}

« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »