Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1109073002: Diable cloud import when Files.app launches as a dialog. (Closed)

Created:
5 years, 8 months ago by fukino
Modified:
5 years, 7 months ago
Reviewers:
Steve McKay
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Diable cloud import when Files.app launches as a dialog. - instantiate ImportController only when the Files.app type is PAGE_FULL. - remove unused flag 'importEnabled_'. BUG=454148 TEST=manual test Committed: https://crrev.com/df0e26664beb1101a3325ead9174cffcd0d33f72 Cr-Commit-Position: refs/heads/master@{#327305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -31 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 3 chunks +16 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
PTAL. Thanks!
5 years, 8 months ago (2015-04-28 04:37:46 UTC) #2
Steve McKay
lgtm
5 years, 7 months ago (2015-04-28 16:31:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109073002/1
5 years, 7 months ago (2015-04-28 16:32:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 16:59:26 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 17:00:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df0e26664beb1101a3325ead9174cffcd0d33f72
Cr-Commit-Position: refs/heads/master@{#327305}

Powered by Google App Engine
This is Rietveld 408576698