Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: lib/src/version.dart

Issue 1109053002: pkg/pub_semver: remove analyzer warnings (Closed) Base URL: https://github.com/dart-lang/pub_semver.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « codereview.settings ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/version.dart
diff --git a/lib/src/version.dart b/lib/src/version.dart
index 2821e27e392deae8ff1b4e2d0984308910450fe4..2bf535fcc94f2687c5809e9b1d721f5cfea58b68 100644
--- a/lib/src/version.dart
+++ b/lib/src/version.dart
@@ -122,7 +122,7 @@ class Version implements Comparable<Version>, VersionConstraint {
String build = match[8];
return new Version._(major, minor, patch, preRelease, build, text);
- } on FormatException catch (ex) {
+ } on FormatException {
throw new FormatException('Could not parse "$text".');
}
}
@@ -149,7 +149,7 @@ class Version implements Comparable<Version>, VersionConstraint {
return text.split('.').map((part) {
try {
return int.parse(part);
- } on FormatException catch (ex) {
+ } on FormatException {
// Not a number.
return part;
}
« no previous file with comments | « codereview.settings ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698