Add a CrBuild command to ninja-build.vim

Add a CrBuild command to ninja-build.vim

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162079

[Nico, 2012-10-15 22:41:35]

Oooh, I wanted to do this myself for a while. Thanks for looking at this!

https://codereview.chromium.org/11090084/diff/1/tools/vim/ninja-build.vim
File tools/vim/ninja-build.vim (right):

https://codereview.chromium.org/11090084/diff/1/tools/vim/ninja-build.vim#new...
tools/vim/ninja-build.vim:10: "
Can you mention this up here too?

https://codereview.chromium.org/11090084/diff/1/tools/vim/ninja-build.vim#new...
tools/vim/ninja-build.vim:100: fun! CrCompileTarget(...)
This does more than just compiling. Maybe CrBuildTarget? (Nice from an
autocompletion perspective too, since "CrB" is now a unique prefix.) And maybe
CrBuild is enough too, but I don't care too much about the "Target" suffix.

Finally, should this build 'chrome' if no target is mentioned explicitly? That's
probably the more common case?

https://codereview.chromium.org/11090084/diff/1/tools/vim/ninja-build.vim#new...
tools/vim/ninja-build.vim:109: endfun
Can you think of a way to not make this function look like an almost-identical
copy of the previous one? (Maybe make both delegate to a new 3rd function that
contains the actual code, with the function to call being a parameter?)

[enne (OOO), 2012-10-16 00:09:17]

ptal

https://codereview.chromium.org/11090084/diff/1/tools/vim/ninja-build.vim
File tools/vim/ninja-build.vim (right):

https://codereview.chromium.org/11090084/diff/1/tools/vim/ninja-build.vim#new...
tools/vim/ninja-build.vim:10: "
On 2012/10/15 22:41:35, Nico wrote:
> Can you mention this up here too?

Done.

https://codereview.chromium.org/11090084/diff/1/tools/vim/ninja-build.vim#new...
tools/vim/ninja-build.vim:100: fun! CrCompileTarget(...)
On 2012/10/15 22:41:35, Nico wrote:
> This does more than just compiling. Maybe CrBuildTarget? (Nice from an
> autocompletion perspective too, since "CrB" is now a unique prefix.) And maybe
> CrBuild is enough too, but I don't care too much about the "Target" suffix.
> 
> Finally, should this build 'chrome' if no target is mentioned explicitly?
That's
> probably the more common case?

I have mixed feelings about default building chrome.  How do you build
everything, then?

https://codereview.chromium.org/11090084/diff/1/tools/vim/ninja-build.vim#new...
tools/vim/ninja-build.vim:109: endfun
On 2012/10/15 22:41:35, Nico wrote:
> Can you think of a way to not make this function look like an almost-identical
> copy of the previous one? (Maybe make both delegate to a new 3rd function that
> contains the actual code, with the function to call being a parameter?)

Yeah, yeah.  I was optimizing for minimal vimscript writing.  Now I understand
how to return values from python functions to Vim and my brain is broken.

[Nico, 2012-10-16 03:22:15]

lgtm!

Update CL description with the new function name before landing please.

[scherkus (not reviewing), 2012-10-17 00:13:49]

¡neato!

[tfarina, 2012-10-17 01:53:01]

http://codereview.chromium.org/11090084/diff/5001/tools/vim/ninja-build.vim
File tools/vim/ninja-build.vim (right):

http://codereview.chromium.org/11090084/diff/5001/tools/vim/ninja-build.vim#n...
tools/vim/ninja-build.vim:6: " this command. On Windows, Ctrl-F7 (which is the
same as the VS default).
Is there a keystroke for Linux/Unix as well?

[Nico, 2012-10-17 02:10:51]

http://codereview.chromium.org/11090084/diff/5001/tools/vim/ninja-build.vim
File tools/vim/ninja-build.vim (right):

http://codereview.chromium.org/11090084/diff/5001/tools/vim/ninja-build.vim#n...
tools/vim/ninja-build.vim:6: " this command. On Windows, Ctrl-F7 (which is the
same as the VS default).
On 2012/10/17 01:53:02, tfarina wrote:
> Is there a keystroke for Linux/Unix as well? 

see line 127 (unrelated to tjis cl tho)

[tfarina, 2012-10-17 06:34:40]

> On 2012/10/17 01:53:02, tfarina wrote:
> > Is there a keystroke for Linux/Unix as well? 
> 
> see line 127 (unrelated to tjis cl tho)
Ah cool. It's \o