Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 11090079: Include svn revsion in AddIn Version (Closed)

Created:
8 years, 2 months ago by Sam Clegg
Modified:
8 years, 2 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

This allows the user to easily see which revision of the AddIn he/she is using. This is done in a slightly unpleasant way in that it modifies the AssemblyInfo.cs in place before the build but this seems to be what all the recommended techniques also do in MS land. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1445

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -9 lines) Patch
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/AssemblyInfo.cs View 1 chunk +6 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/buildbot_run.py View 2 chunks +36 lines, -1 line 1 comment Download
M visual_studio/NativeClientVSAddIn/create_package.py View 1 chunk +6 lines, -6 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Sam Clegg
8 years, 2 months ago (2012-10-11 20:03:46 UTC) #1
binji
8 years, 2 months ago (2012-10-11 20:23:00 UTC) #2
lgtm

http://codereview.chromium.org/11090079/diff/1001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/buildbot_run.py (right):

http://codereview.chromium.org/11090079/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/buildbot_run.py:72: pattern = r'(\[assembly:
AssemblyInformationalVersion\("\d+\.\d+\.).*"\)\]'
I think this regexp should extract the end part too... also, use a non-greedy
match for the part you're replacing:

\("\d+\.\d+\.).*?("\)\])

then sub using \1%s\2

Could also use lookbehind and lookahead assertions here, but maybe that's
overkill.

http://codereview.chromium.org/11090079/diff/1001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/create_package.py (right):

http://codereview.chromium.org/11090079/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/create_package.py:104: path =
u'\\StringFileInfo\\%04X%04X\\ProductVersion' % (lang, codepage)
needs to be unicode string?

Powered by Google App Engine
This is Rietveld 408576698