Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 11090069: Android: Make webview builds more convenient. (Closed)

Created:
8 years, 2 months ago by Torne
Modified:
8 years, 2 months ago
CC:
chromium-reviews, pam+watch_chromium.org, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Android: Make webview builds more convenient. Allow the top level Android.mk to include GypAndroid.mk if the relevant environment variable is set, to avoid having to edit this file to build in the Android tree without breaking other Android builds. Also, provide a gyp wrapper for webview which passes the correct options. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161566

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M Android.mk View 1 chunk +9 lines, -2 lines 0 comments Download
A android_webview/tools/gyp_webview View 1 chunk +17 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
Torne
8 years, 2 months ago (2012-10-11 15:04:49 UTC) #1
Torne
+yfriedman Yaron, are you okay with this top level Android.mk change? It saves us having ...
8 years, 2 months ago (2012-10-11 15:07:26 UTC) #2
mnaganov (inactive)
lgtm
8 years, 2 months ago (2012-10-11 15:11:05 UTC) #3
Yaron
lgtm FYI: Bo was able to remove all the existing Android.mk files https://codereview.chromium.org/11090069/diff/1/android_webview/tools/gyp_webview File android_webview/tools/gyp_webview ...
8 years, 2 months ago (2012-10-12 00:15:17 UTC) #4
Torne
On 2012/10/12 00:15:17, Yaron wrote: > lgtm > > FYI: Bo was able to remove ...
8 years, 2 months ago (2012-10-12 10:00:52 UTC) #5
Torne
https://codereview.chromium.org/11090069/diff/1/android_webview/tools/gyp_webview File android_webview/tools/gyp_webview (right): https://codereview.chromium.org/11090069/diff/1/android_webview/tools/gyp_webview#newcode17 android_webview/tools/gyp_webview:17: android_gyp On 2012/10/12 00:15:17, Yaron wrote: > Did you ...
8 years, 2 months ago (2012-10-12 10:01:01 UTC) #6
boliu
8 years, 2 months ago (2012-10-12 14:10:54 UTC) #7
On 2012/10/12 10:00:52, Torne wrote:
> On 2012/10/12 00:15:17, Yaron wrote:
> > lgtm
> > 
> > FYI: Bo was able to remove all the existing Android.mk files
> 
> Well, we still need an Android.mk in the top level anyway, since a bunch of
the
> third_party directories have them and otherwise things will go wrong when
> chromium is checked out inside an android tree. :)
> 
I didn't delete the top level one downstream, so should be ok.

Powered by Google App Engine
This is Rietveld 408576698