content/public/browser/web_contents_observer.h - Issue 11090068: When starting a provisional load include the parent frame ID in the IPC and pass it down the th WCO…

Side by Side Diff: content/public/browser/web_contents_observer.h

Issue 11090068: When starting a provisional load include the parent frame ID in the IPC and pass it down the th WCO… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_	5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_

6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_	6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_

7	7

8 #include "base/callback_forward.h"	8 #include "base/callback_forward.h"

9 #include "base/process_util.h"	9 #include "base/process_util.h"

10 #include "content/common/content_export.h"	10 #include "content/common/content_export.h"

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 virtual void DidNavigateMainFrame(	45 virtual void DidNavigateMainFrame(

46 const LoadCommittedDetails& details,	46 const LoadCommittedDetails& details,

47 const FrameNavigateParams& params) {}	47 const FrameNavigateParams& params) {}

48 virtual void DidNavigateAnyFrame(	48 virtual void DidNavigateAnyFrame(

49 const LoadCommittedDetails& details,	49 const LoadCommittedDetails& details,

50 const FrameNavigateParams& params) {}	50 const FrameNavigateParams& params) {}

51 // \|render_view_host\| is the RenderViewHost for which the provisional load is	51 // \|render_view_host\| is the RenderViewHost for which the provisional load is

52 // happening.	52 // happening.

53 virtual void DidStartProvisionalLoadForFrame(	53 virtual void DidStartProvisionalLoadForFrame(

54 int64 frame_id,	54 int64 frame_id,

	55 int64 parent_frame_id,
	Bernhard Bauer 2012/10/12 08:32:49 Some tests appear to use -1 here. Could you add a Some tests appear to use -1 here. Could you add a comment what that value means? jochen (gone - plz use gerrit) 2012/10/12 10:44:48 Done. Show quoted text On 2012/10/12 08:32:49, Bernhard Bauer wrote: > Some tests appear to use -1 here. Could you add a comment what that value means? Done.
55 bool is_main_frame,	56 bool is_main_frame,

56 const GURL& validated_url,	57 const GURL& validated_url,

57 bool is_error_page,	58 bool is_error_page,

58 RenderViewHost* render_view_host) {}	59 RenderViewHost* render_view_host) {}

59 virtual void ProvisionalChangeToMainFrameUrl(	60 virtual void ProvisionalChangeToMainFrameUrl(

60 const GURL& url,	61 const GURL& url,

61 const GURL& opener_url,	62 const GURL& opener_url,

62 RenderViewHost* render_view_host) {}	63 RenderViewHost* render_view_host) {}

63 virtual void DidCommitProvisionalLoadForFrame(	64 virtual void DidCommitProvisionalLoadForFrame(

64 int64 frame_id,	65 int64 frame_id,

(...skipping 113 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
178 void WebContentsImplDestroyed();	179 void WebContentsImplDestroyed();

179	180

180 WebContentsImpl* web_contents_;	181 WebContentsImpl* web_contents_;

181	182

182 DISALLOW_COPY_AND_ASSIGN(WebContentsObserver);	183 DISALLOW_COPY_AND_ASSIGN(WebContentsObserver);

183 };	184 };

184	185

185 } // namespace content	186 } // namespace content

186	187

187 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_	188 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_

OLD	NEW