Spekulative fix for version.dart on windows

tools/testing/dart/version.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file contains functionality for getting dart version numbers using
  * our standard version construction method. Systems that does not include this
  * file should emulate the structure for revision numbers that we have here.
  *
  * The version number of a dart build is constructed as follows:
@@ skipping 77 matching lines @@
             c.completeException("Wrong format in VERSION file, line does not "
                                 "contain one of {MAJOR, MINOR, BUILD, PATCH}");
             return;
         }
       };
       input.onClosed = () {
         // Only complete if we did not already complete with a failure.
         if (!c.future.isComplete) {
           getRevision().then((revision) {
             REVISION = revision;
-            getUserName().then((username) {
-              USERNAME = username;
-              if (username != '') username = "_$username";
-              var revisionString = "";
-              if (revision != 0) revisionString = "_r$revision";
-              c.complete("$MAJOR.$MINOR.$BUILD.$PATCH$revisionString$username");
-              return;
-            });
+            USERNAME = getUserName();
+            var userNameString = "";
+            if (USERNAME != '') userNameString = "_$USERNAME";
+            var revisionString = "";
+            if (revision != 0) revisionString = "_r$revision";
+            c.complete(
+                "$MAJOR.$MINOR.$BUILD.$PATCH$revisionString$userNameString");
+            return;
           });
         }
       };
     });
     return c.future;
   }
 
+  String getExecutableSuffix() {
+    if (Platform.operatingSystem == 'windows') {
+      return '.exe';
+    }
+    return '';
+  }
+
   Future<int> getRevision() {
     if (repositoryType == RepositoryType.UNKNOWN) {
       return new Future.immediate(0);
     }
     var isSvn = repositoryType == RepositoryType.SVN;
     var command = isSvn ? "svn" : "git";
+    command = "$command${getExecutableSuffix()}";
     var arguments = isSvn ? ["info"] : ["svn", "info"];
     return Process.run(command, arguments).transform((result) {
       if (result.exitCode != 0) {
         return 0;
       }
       // If anything goes wrong parsing the revision we simply return 0.
       try {
         // Extract the revision. It's located at the 8th line,
         // 18 characters in.
         String revisionString = result.stdout.split("\n")[8].substring(18);
         return int.parse(revisionString);
       } catch (e) {
         return 0;
       }
     });
   }
 
-  Future<String> getUserName() {
+  String getUserName() {
     // TODO(ricow): Don't add this on the buildbot.
-    // If we can't get the username simple return "" (e.g. on windows).
-    return Process.run("whoami", []).transform((result) {
-      if (result.exitCode != 0) {
-        return "";
-      }
-      return result.stdout;
-    }).transformException((e) {
-      return "";
-    });
+    if (!Platform.environment.containsKey("USER")) return "";
+    return Platform.environment["USER"];
   }
 
   RepositoryType get repositoryType {
     if (new Directory(".svn").existsSync()) return RepositoryType.SVN;
     if (new Directory(".git").existsSync()) return RepositoryType.GIT;
     return RepositoryType.UNKNOWN;
   }
 }
 
 class RepositoryType {
   static final RepositoryType SVN = const RepositoryType("SVN");
   static final RepositoryType GIT = const RepositoryType("GIT");
   static final RepositoryType UNKNOWN = const RepositoryType("UNKNOWN");
 
   const RepositoryType(String this.name);
 
   static RepositoryType guessType() {
     if (new Directory(".svn").existsSync()) return RepositoryType.SVN;
     if (new Directory(".git").existsSync()) return RepositoryType.GIT;
     return RepositoryType.UNKNOWN;
   }
 
   String toString() => name;
 
   final String name;
 }