Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 11090061: Fix the crash that was happening on the buildbot (but not trybots, for a strange reason) because Re… (Closed)

Created:
8 years, 2 months ago by jam
Modified:
8 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix the crash that was happening on the buildbot (but not trybots, for a strange reason) because ResourceBundle was initialized twice for tests that use the RenderViewTest harness. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161256

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_view_browsertest_mac.mm View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_accessibility_browsertest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 2 months ago (2012-10-10 23:23:48 UTC) #1
cpu_(ooo_6.6-7.5)
8 years, 2 months ago (2012-10-10 23:36:21 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698