[Mac] In BrowserWindowCocoa::Close() do not use -[NSWindow performClose:].

chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_util.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
-#include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
-#include "chrome/browser/ui/cocoa/browser_window_controller.h"
+#import "chrome/browser/ui/cocoa/browser_window_cocoa.h"
+#import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/notification_details.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#import "third_party/ocmock/gtest_support.h"
+#import "third_party/ocmock/ocmock/OCMock.h"
 
 // A BrowserWindowCocoa that goes PONG when
 // BOOKMARK_BAR_VISIBILITY_PREF_CHANGED is sent.  This is so we can be
 // sure we are observing it.
 class BrowserWindowCocoaPong : public BrowserWindowCocoa {
  public:
   BrowserWindowCocoaPong(Browser* browser,
                          BrowserWindowController* controller)
       : BrowserWindowCocoa(browser, controller) {
     pong_ = false;
@@ skipping 93 matching lines @@
   scoped_ptr<BrowserWindowCocoaPong> scoped_bwc(bwc);
 
   EXPECT_FALSE(bwc->IsFullscreen());
   bwc->EnterFullscreen(GURL(), FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION);
   EXPECT_TRUE(bwc->IsFullscreen());
   bwc->ExitFullscreen();
   EXPECT_FALSE(bwc->IsFullscreen());
   [fake_controller close];
 }
 
+// Tests that BrowserWindowCocoa::Close mimicks the behavior of

[Mark Mentovai, 2012/10/11 15:44:57]

mimics

[Robert Sesek, 2012/10/11 15:58:39]

Done.

+// -[NSWindow performClose:].
+class BrowserWindowCocoaCloseTest : public CocoaProfileTest {
+ public:
+  BrowserWindowCocoaCloseTest()
+      : controller_(
+            [OCMockObject mockForClass:[BrowserWindowController class]]),
+        window_([OCMockObject mockForClass:[NSWindow class]]) {
+    [[[controller_ stub] andReturn:nil] overlayWindow];
+  }
+
+  void CreateAndCloseBrowserWindow() {
+    BrowserWindowCocoa browser_window(browser(), controller_);
+    browser_window.Close();
+  }
+
+  id ValueYES() {
+    BOOL v = YES;
+    return OCMOCK_VALUE(v);
+  }
+  id ValueNO() {
+    BOOL v = NO;
+    return OCMOCK_VALUE(v);
+  }
+
+ protected:
+  id controller_;
+  id window_;
+};
+
+TEST_F(BrowserWindowCocoaCloseTest, DelegateRespondsYes) {
+  [[[window_ stub] andReturn:controller_] delegate];
+  [[[controller_ stub] andReturn:window_] window];
+  [[[controller_ stub] andReturnValue:ValueYES()] windowShouldClose:window_];
+  [[window_ expect] close];
+  CreateAndCloseBrowserWindow();
+  EXPECT_OCMOCK_VERIFY(controller_);
+  EXPECT_OCMOCK_VERIFY(window_);
+}
+
+TEST_F(BrowserWindowCocoaCloseTest, DelegateRespondsNo) {
+  [[[window_ stub] andReturn:controller_] delegate];
+  [[[controller_ stub] andReturn:window_] window];
+  [[[controller_ stub] andReturnValue:ValueNO()] windowShouldClose:window_];
+  CreateAndCloseBrowserWindow();
+  EXPECT_OCMOCK_VERIFY(controller_);
+  EXPECT_OCMOCK_VERIFY(window_);
+}
+
+// NSWindow does not implement |-windowShouldClose:|, but subclasses can
+// implement it, and |-performClose:| will invoke it if implemented.
+@interface BrowserWindowCocoaCloseWindow : NSWindow
+- (BOOL)windowShouldClose:(id)window;
+@end
+@implementation BrowserWindowCocoaCloseWindow
+- (BOOL)windowShouldClose:(id)window {
+  return YES;
+}
+@end
+
+TEST_F(BrowserWindowCocoaCloseTest, WindowRespondsYes) {
+  window_ = [OCMockObject mockForClass:[BrowserWindowCocoaCloseWindow class]];
+  [[[window_ stub] andReturn:nil] delegate];
+  [[[controller_ stub] andReturn:window_] window];
+  [[[window_ stub] andReturnValue:ValueYES()] windowShouldClose:window_];
+  [[window_ expect] close];
+  CreateAndCloseBrowserWindow();
+  EXPECT_OCMOCK_VERIFY(controller_);
+  EXPECT_OCMOCK_VERIFY(window_);
+}
+
+TEST_F(BrowserWindowCocoaCloseTest, WindowRespondsNo) {
+  window_ = [OCMockObject mockForClass:[BrowserWindowCocoaCloseWindow class]];
+  [[[window_ stub] andReturn:nil] delegate];
+  [[[controller_ stub] andReturn:window_] window];
+  [[[window_ stub] andReturnValue:ValueNO()] windowShouldClose:window_];
+  CreateAndCloseBrowserWindow();
+  EXPECT_OCMOCK_VERIFY(controller_);
+  EXPECT_OCMOCK_VERIFY(window_);
+}
+

[Mark Mentovai, 2012/10/11 15:44:57]

Can you also have a test where the delegate says YES but the window says NO, and
verify that the window does close? And vice-versa?

[Robert Sesek, 2012/10/11 15:58:39]

Done, and the inverse

+TEST_F(BrowserWindowCocoaCloseTest, NoResponseFromDelegatAndWindow) {

[Mark Mentovai, 2012/10/11 15:44:57]

Delegate is missing an E.

[Robert Sesek, 2012/10/11 15:58:39]

Done.

+  [[[window_ stub] andReturn:nil] delegate];
+  [[[controller_ stub] andReturn:window_] window];
+  [[window_ expect] close];
+  CreateAndCloseBrowserWindow();
+  EXPECT_OCMOCK_VERIFY(controller_);
+  EXPECT_OCMOCK_VERIFY(window_);
+}
+
 // TODO(???): test other methods of BrowserWindowCocoa