Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: runtime/vm/code_generator.cc

Issue 11090027: Address Florian's comments. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/code_generator.h" 5 #include "vm/code_generator.h"
6 6
7 #include "vm/assembler_macros.h" 7 #include "vm/assembler_macros.h"
8 #include "vm/ast.h" 8 #include "vm/ast.h"
9 #include "vm/code_patcher.h" 9 #include "vm/code_patcher.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 971 matching lines...) Expand 10 before | Expand all | Expand 10 after
982 args.Add(&receiver); 982 args.Add(&receiver);
983 args.Add(&arg1); 983 args.Add(&arg1);
984 args.Add(&arg2); 984 args.Add(&arg2);
985 const Function& result = 985 const Function& result =
986 Function::Handle(InlineCacheMissHandler(isolate, args)); 986 Function::Handle(InlineCacheMissHandler(isolate, args));
987 arguments.SetReturn(result); 987 arguments.SetReturn(result);
988 } 988 }
989 989
990 990
991 // Updates IC data for two arguments. Used by the equality operation when 991 // Updates IC data for two arguments. Used by the equality operation when
992 // teh control flow bypasses regular inline cache (null arguments). 992 // the control flow bypasses regular inline cache (null arguments).
993 // Arg0: Receiver object. 993 // Arg0: Receiver object.
994 // Arg1: Argument after receiver. 994 // Arg1: Argument after receiver.
995 // Arg2: Target's name. 995 // Arg2: Target's name.
996 // Arg3: ICData. 996 // Arg3: ICData.
997 DEFINE_RUNTIME_ENTRY(UpdateICDataTwoArgs, 4) { 997 DEFINE_RUNTIME_ENTRY(UpdateICDataTwoArgs, 4) {
998 ASSERT(arguments.Count() == 998 ASSERT(arguments.Count() ==
999 kUpdateICDataTwoArgsRuntimeEntry.argument_count()); 999 kUpdateICDataTwoArgsRuntimeEntry.argument_count());
1000 const Instance& receiver = Instance::CheckedHandle(arguments.At(0)); 1000 const Instance& receiver = Instance::CheckedHandle(arguments.At(0));
1001 const Instance& arg1 = Instance::CheckedHandle(arguments.At(1)); 1001 const Instance& arg1 = Instance::CheckedHandle(arguments.At(1));
1002 const String& target_name = String::CheckedHandle(arguments.At(2)); 1002 const String& target_name = String::CheckedHandle(arguments.At(2));
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
1752 intptr_t line, column; 1752 intptr_t line, column;
1753 script.GetTokenLocation(token_pos, &line, &column); 1753 script.GetTokenLocation(token_pos, &line, &column);
1754 String& line_string = String::Handle(script.GetLine(line)); 1754 String& line_string = String::Handle(script.GetLine(line));
1755 OS::Print(" Function: %s\n", top_function.ToFullyQualifiedCString()); 1755 OS::Print(" Function: %s\n", top_function.ToFullyQualifiedCString());
1756 OS::Print(" Line %"Pd": '%s'\n", line, line_string.ToCString()); 1756 OS::Print(" Line %"Pd": '%s'\n", line, line_string.ToCString());
1757 } 1757 }
1758 } 1758 }
1759 1759
1760 1760
1761 } // namespace dart 1761 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698