Improve page flag checking sequence on ARM.

src/arm/macro-assembler-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3479 matching lines @@
   add(result, result, Operand(kPCRegOffset));
 }
 
 
 void MacroAssembler::CheckPageFlag(
     Register object,
     Register scratch,
     int mask,
     Condition cc,
     Label* condition_met) {
-  and_(scratch, object, Operand(~Page::kPageAlignmentMask));
+  Move(scratch, object);

[Please use jfb - chromium.org, 2012/10/09 13:09:21]

Actually, let me retract my LGTM: this will generate an extra move on non-ARMv7
machines. The move should be emitted with the same condition as Bfc:
if (!CpuFeatures::IsSupported(ARMv7) || predictable_code_size())

[Michael Starzinger, 2012/10/09 13:36:20]

Done. You are right, I totally missed that.

+  Bfc(scratch, 0, kPageSizeBits);

[m.m.capewell, 2012/10/09 13:25:27]

A more generic way of doing this, possibly with slightly better performance, is
using two shifts, right then left, by kPageSizeBits.

[Michael Starzinger, 2012/10/09 13:54:34]

So just to clarify. Do you think that the two-shift-approach would perform
better than move+bfc on ARMv7? That would surprise me, but I am no ARM expert.

My approach would be to always use move+bfc on ARMv7 and only use the
two-shift-approach when we are running on non-ARMv7 and (lsb == 0). Need to find
a non-ARMv7 device for measurements.

   ldr(scratch, MemOperand(scratch, MemoryChunk::kFlagsOffset));
   tst(scratch, Operand(mask));
   b(cc, condition_met);
 }
 
 
 void MacroAssembler::JumpIfBlack(Register object,
                                  Register scratch0,
                                  Register scratch1,
                                  Label* on_black) {
@@ skipping 343 matching lines @@
 void CodePatcher::EmitCondition(Condition cond) {
   Instr instr = Assembler::instr_at(masm_.pc_);
   instr = (instr & ~kCondMask) | cond;
   masm_.emit(instr);
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM