Issue 11090019: Add LocalFileSyncContext class which wires up profile-owned service and FileSystemContext(s)

Issue 11090019: Add LocalFileSyncContext class which wires up profile-owned service and FileSystemContext(s) (Closed)

Created:
8 years, 2 months ago by kinuko

Modified:
8 years, 2 months ago

Reviewers:
jam, tzik

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org, nhiroki, calvinlo

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add LocalFileSyncContext class which is a glue class between profile-owned service and FileSystemContext(s) BUG=154234 TEST=LocalFileSyncContextTest.* TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161556

Patch Set 3 : addressed comments #2 #

Total comments: 2

Patch Set 4 : addressed comments #4 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+490 lines, -0 lines)			Patch
M	content/content_tests.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/fileapi/file_system_context.h	View	1 2 3	3 chunks	+5 lines, -0 lines	0 comments	Download
M	webkit/fileapi/file_system_context.cc	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/fileapi/syncable/canned_syncable_file_system.h	View	1 2 3	5 chunks	+12 lines, -0 lines	0 comments	Download
M	webkit/fileapi/syncable/canned_syncable_file_system.cc	View	1 2 3	10 chunks	+34 lines, -0 lines	0 comments	Download
A	webkit/fileapi/syncable/local_file_sync_context.h	View	1 2 3	1 chunk	+105 lines, -0 lines	0 comments	Download
A	webkit/fileapi/syncable/local_file_sync_context.cc	View	1 2 3	1 chunk	+157 lines, -0 lines	0 comments	Download
A	webkit/fileapi/syncable/local_file_sync_context_unittest.cc	View	1 2 3	1 chunk	+168 lines, -0 lines	0 comments	Download
M	webkit/fileapi/webkit_fileapi.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tzik

Looks good. I'll look into tomorrow. (sorry for slow review) http://codereview.chromium.org/11090019/diff/4001/webkit/fileapi/file_system_context.cc File webkit/fileapi/file_system_context.cc (right): http://codereview.chromium.org/11090019/diff/4001/webkit/fileapi/file_system_context.cc#newcode23 ...

8 years, 2 months ago (2012-10-11 09:42:53 UTC) #2

kinuko

Thanks, updated. http://codereview.chromium.org/11090019/diff/4001/webkit/fileapi/file_system_context.cc File webkit/fileapi/file_system_context.cc (right): http://codereview.chromium.org/11090019/diff/4001/webkit/fileapi/file_system_context.cc#newcode23 webkit/fileapi/file_system_context.cc:23: #include "webkit/fileapi/syncable/syncable_context.h" On 2012/10/11 09:42:53, tzik wrote: ...

8 years, 2 months ago (2012-10-11 10:13:01 UTC) #3

tzik

LGTM http://codereview.chromium.org/11090019/diff/11003/webkit/fileapi/syncable/canned_syncable_file_system.cc File webkit/fileapi/syncable/canned_syncable_file_system.cc (right): http://codereview.chromium.org/11090019/diff/11003/webkit/fileapi/syncable/canned_syncable_file_system.cc#newcode92 webkit/fileapi/syncable/canned_syncable_file_system.cc:92: sync_status_ = SYNC_FILE_ERROR_FAILED; can we use SYNC_STATUS_UNKNOWN instead?

8 years, 2 months ago (2012-10-12 07:02:20 UTC) #4

kinuko

http://codereview.chromium.org/11090019/diff/11003/webkit/fileapi/syncable/canned_syncable_file_system.cc File webkit/fileapi/syncable/canned_syncable_file_system.cc (right): http://codereview.chromium.org/11090019/diff/11003/webkit/fileapi/syncable/canned_syncable_file_system.cc#newcode92 webkit/fileapi/syncable/canned_syncable_file_system.cc:92: sync_status_ = SYNC_FILE_ERROR_FAILED; On 2012/10/12 07:02:20, tzik wrote: > ...

8 years, 2 months ago (2012-10-12 07:17:30 UTC) #5

kinuko

8 years, 2 months ago (2012-10-12 11:28:11 UTC) #7

jam@, can you rubber stamp a one-line gyp change in content/content_tests.gypi?
Thanks!

Expand Messages | Collapse Messages