Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: utils/pub/io.dart

Issue 11090016: Change core lib, dart2js, and more for new optional parameters syntax (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/hosted_source.dart ('k') | utils/pub/source.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
===================================================================
--- utils/pub/io.dart (revision 13683)
+++ utils/pub/io.dart (working copy)
@@ -481,8 +481,8 @@
* piped streams won't be available in the result object.
*/
Future<PubProcessResult> runProcess(String executable, List<String> args,
- [workingDir, Map<String, String> environment, bool pipeStdout = false,
- bool pipeStderr = false]) {
+ {workingDir, Map<String, String> environment, bool pipeStdout: false,
+ bool pipeStderr: false}) {
int exitCode;
// TODO(rnystrom): Should dart:io just handle this?
@@ -556,8 +556,8 @@
}
/// Run a git process with [args] from [workingDir].
-Future<PubProcessResult> runGit(List<String> args, [String workingDir]) =>
- _gitCommand.chain((git) => runProcess(git, args, workingDir));
+Future<PubProcessResult> runGit(List<String> args, {String workingDir}) =>
+ _gitCommand.chain((git) => runProcess(git, args, workingDir: workingDir));
/// Returns the name of the git command-line app, or null if Git could not be
/// found on the user's PATH.
« no previous file with comments | « utils/pub/hosted_source.dart ('k') | utils/pub/source.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698