Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Unified Diff: pkg/intl/lib/src/date_format_helpers.dart

Issue 11090016: Change core lib, dart2js, and more for new optional parameters syntax (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/intl/example/basic/basic_example.dart ('k') | pkg/intl/test/date_time_format_test_core.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/src/date_format_helpers.dart
===================================================================
--- pkg/intl/lib/src/date_format_helpers.dart (revision 13683)
+++ pkg/intl/lib/src/date_format_helpers.dart (working copy)
@@ -36,15 +36,25 @@
Date asDate() {
// TODO(alanknight): Validate the date, especially for things which
// can crash the VM, e.g. large month values.
- return new Date(
- year,
- month,
- day,
- pm ? hour + 12 : hour,
- minute,
- second,
- fractionalSecond,
- utc);
+ if (utc) {
+ return new Date.utc(
+ year,
+ month,
+ day,
+ pm ? hour + 12 : hour,
+ minute,
+ second,
+ fractionalSecond);
+ } else {
+ return new Date(
+ year,
+ month,
+ day,
+ pm ? hour + 12 : hour,
+ minute,
+ second,
+ fractionalSecond);
+ }
}
}
« no previous file with comments | « pkg/intl/example/basic/basic_example.dart ('k') | pkg/intl/test/date_time_format_test_core.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698