Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 11090016: Change core lib, dart2js, and more for new optional parameters syntax (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/compiler.dart
===================================================================
--- lib/compiler/implementation/compiler.dart (revision 13683)
+++ lib/compiler/implementation/compiler.dart (working copy)
@@ -194,14 +194,14 @@
bool hasCrashed = false;
- Compiler([this.tracer = const Tracer(),
- this.enableTypeAssertions = false,
- this.enableUserAssertions = false,
- this.enableConcreteTypeInference = false,
- this.enableMinification = false,
- bool emitJavaScript = true,
- bool generateSourceMap = true,
- List<String> strips = const []])
+ Compiler({this.tracer: const Tracer(),
+ this.enableTypeAssertions: false,
+ this.enableUserAssertions: false,
+ this.enableConcreteTypeInference: false,
+ this.enableMinification: false,
+ bool emitJavaScript: true,
+ bool generateSourceMap: true,
+ List<String> strips: const []})
: libraries = new Map<String, LibraryElement>(),
progress = new Stopwatch() {
progress.start();
@@ -236,16 +236,19 @@
}
void unimplemented(String methodName,
- [Node node, Token token, HInstruction instruction,
- Element element]) {
+ {Node node, Token token, HInstruction instruction,
+ Element element}) {
internalError("$methodName not implemented",
- node, token, instruction, element);
+ node: node, token: token,
+ instruction: instruction, element: element);
}
void internalError(String message,
- [Node node, Token token, HInstruction instruction,
- Element element]) {
- cancel('Internal error: $message', node, token, instruction, element);
+ {Node node, Token token, HInstruction instruction,
+ Element element}) {
+ cancel('Internal error: $message',
+ node: node, token: token,
+ instruction: instruction, element: element);
}
void internalErrorOnElement(Element element, String message) {
@@ -261,8 +264,8 @@
print(MessageKind.PLEASE_REPORT_THE_CRASH.message([BUILD_ID]));
}
- void cancel([String reason, Node node, Token token,
- HInstruction instruction, Element element]) {
+ void cancel(String reason, {Node node, Token token,
+ HInstruction instruction, Element element}) {
assembledCode = null; // Compilation failed. Make sure that we
// don't return a bogus result.
SourceSpan span = null;
@@ -282,9 +285,10 @@
}
void reportFatalError(String reason, Element element,
- [Node node, Token token, HInstruction instruction]) {
+ {Node node, Token token, HInstruction instruction}) {
withCurrentElement(element, () {
- cancel(reason, node, token, instruction, element);
+ cancel(reason, node: node, token: token, instruction: instruction,
+ element: element);
});
}
« no previous file with comments | « lib/compiler/implementation/compile_time_constants.dart ('k') | lib/compiler/implementation/dart_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698