Change core lib, dart2js, and more for new optional parameters syntax

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart	(revision 13588)
+++ tools/testing/dart/test_suite.dart	(working copy)
@@ -224,8 +224,8 @@
                     this.suiteName,
                     Path suiteDirectory,
                     this.statusFilePaths,
-                    [this.isTestFilePredicate,
-                    bool recursive = false])
+                    {this.isTestFilePredicate,
+                    bool recursive: false})

[Lasse Reichstein Nielsen, 2012/10/12 07:52:19]

Do we have a rule for indentation in cases like this? I would expect the 'bool'
to be indented by one more.

[regis, 2012/10/12 17:51:51]

I am not aware of a rule. I have seen different styles. I agree that it looks
better with a space. In this particular case, we could also write both optional
parameters on the same line. We should have a clean up pass over all sources
when/if we decide that a style is better than another.

   : dartDir = TestUtils.dartDir(), _listRecursive = recursive,
     suiteDir = TestUtils.dartDir().join(suiteDirectory);
 
@@ -263,7 +263,7 @@
     return new StandardTestSuite(configuration,
         name, directory,
         ['$directory/$name.status', '$directory/${name}_dart2js.status'],
-        (filename) => filename.endsWith('_test.dart'),
+        isTestFilePredicate: (filename) => filename.endsWith('_test.dart'),
         recursive: true);
   }