Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: lib/compiler/implementation/lib/coreimpl_patch.dart

Issue 11090016: Change core lib, dart2js, and more for new optional parameters syntax (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/lib/coreimpl_patch.dart
===================================================================
--- lib/compiler/implementation/lib/coreimpl_patch.dart (revision 13392)
+++ lib/compiler/implementation/lib/coreimpl_patch.dart (working copy)
@@ -74,13 +74,13 @@
// in patch files?
patch class DateImplementation {
patch DateImplementation(int year,
- [int month = 1,
- int day = 1,
- int hour = 0,
- int minute = 0,
- int second = 0,
- int millisecond = 0,
- bool isUtc = false])
+ {int month: 1,
Lasse Reichstein Nielsen 2012/10/09 12:35:00 The implementation class should not have optional
regis 2012/10/11 01:33:56 Done.
+ int day: 1,
+ int hour: 0,
+ int minute: 0,
+ int second: 0,
+ int millisecond: 0,
+ bool isUtc: false})
: this.isUtc = checkNull(isUtc),
millisecondsSinceEpoch = Primitives.valueFromDecomposedDate(
year, month, day, hour, minute, second, millisecond, isUtc) {

Powered by Google App Engine
This is Rietveld 408576698