Change core lib, dart2js, and more for new optional parameters syntax

lib/coreimpl/date.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class DateImplementation implements Date {
   final int millisecondsSinceEpoch;
   final bool isUtc;
 
   factory DateImplementation.fromString(String formattedString) {
     // Read in (a subset of) ISO 8601.
@@ skipping 35 matching lines @@
         millisecond = 999;
       }
       // TODO(floitsch): we should not need to test against the empty string.
       bool isUtc = (match[8] !== null) && (match[8] != "");
       int millisecondsSinceEpoch = _brokenDownDateToMillisecondsSinceEpoch(
           years, month, day, hour, minute, second, millisecond, isUtc);
       if (millisecondsSinceEpoch === null) {
         throw new ArgumentError(formattedString);
       }
       if (addOneMillisecond) millisecondsSinceEpoch++;
-      return new Date.fromMillisecondsSinceEpoch(millisecondsSinceEpoch, isUtc);
+      return new Date.fromMillisecondsSinceEpoch(millisecondsSinceEpoch,
+                                                 isUtc: isUtc);
     } else {
       throw new ArgumentError(formattedString);
     }
   }
 
   static const int _MAX_MILLISECONDS_SINCE_EPOCH = 8640000000000000;
 
   DateImplementation.fromMillisecondsSinceEpoch(this.millisecondsSinceEpoch,
                                                 this.isUtc) {
     if (millisecondsSinceEpoch.abs() > _MAX_MILLISECONDS_SINCE_EPOCH) {
@@ skipping 19 matching lines @@
   bool operator >=(Date other)
       => millisecondsSinceEpoch >= other.millisecondsSinceEpoch;
 
   int compareTo(Date other)
       => millisecondsSinceEpoch.compareTo(other.millisecondsSinceEpoch);
 
   int hashCode() => millisecondsSinceEpoch;
 
   Date toLocal() {
     if (isUtc) {
-      return new Date.fromMillisecondsSinceEpoch(millisecondsSinceEpoch, false);
+      return new Date.fromMillisecondsSinceEpoch(millisecondsSinceEpoch,
+                                                 isUtc: false);
     }
     return this;
   }
 
   Date toUtc() {
     if (isUtc) return this;
-    return new Date.fromMillisecondsSinceEpoch(millisecondsSinceEpoch, true);
+    return new Date.fromMillisecondsSinceEpoch(millisecondsSinceEpoch,
+                                               isUtc: true);
   }
 
   String toString() {
     String fourDigits(int n) {
       int absN = n.abs();
       String sign = n < 0 ? "-" : "";
       if (absN >= 1000) return "$n";
       if (absN >= 100) return "${sign}0$absN";
       if (absN >= 10) return "${sign}00$absN";
       return "${sign}000$absN";
@@ skipping 21 matching lines @@
       return "$y-$m-$d $h:$min:$sec.${ms}Z";
     } else {
       return "$y-$m-$d $h:$min:$sec.$ms";
     }
   }
 
   /** Returns a new [Date] with the [duration] added to [this]. */
   Date add(Duration duration) {
     int ms = millisecondsSinceEpoch;
     return new Date.fromMillisecondsSinceEpoch(
-        ms + duration.inMilliseconds, isUtc);
+        ms + duration.inMilliseconds, isUtc: isUtc);
   }
 
   /** Returns a new [Date] with the [duration] subtracted from [this]. */
   Date subtract(Duration duration) {
     int ms = millisecondsSinceEpoch;
     return new Date.fromMillisecondsSinceEpoch(
-        ms - duration.inMilliseconds, isUtc);
+        ms - duration.inMilliseconds, isUtc: isUtc);
   }
 
   /** Returns a [Duration] with the difference of [this] and [other]. */
   Duration difference(Date other) {
     int ms = millisecondsSinceEpoch;
     int otherMs = other.millisecondsSinceEpoch;
     return new Duration(milliseconds: ms - otherMs);
   }
 
   // TODO(lrn): Make parameters not optional for the implementation class.

[Lasse Reichstein Nielsen, 2012/10/09 12:35:00]

Do the TODO :)

[regis, 2012/10/11 01:33:56]

Done.

   external DateImplementation(int year,
-                              [int month = 1,
-                               int day = 1,
-                               int hour = 0,
-                               int minute = 0,
-                               int second = 0,
-                               int millisecond = 0,
-                               bool isUtc = false]);
+                              {int month: 1,
+                               int day: 1,
+                               int hour: 0,
+                               int minute: 0,
+                               int second: 0,
+                               int millisecond: 0,
+                               bool isUtc: false});
   external DateImplementation.now();
   external static int _brokenDownDateToMillisecondsSinceEpoch(
       int year, int month, int day, int hour, int minute, int second,
       int millisecond, bool isUtc);
   external String get timeZoneName;
   external Duration get timeZoneOffset;
   external int get year;
   external int get month;
   external int get day;
   external int get hour;
   external int get minute;
   external int get second;
   external int get millisecond;
   external int get weekday;
 }