Change core lib, dart2js, and more for new optional parameters syntax

lib/core/date.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Dart core library.
 
 /**
  * Date is the public interface to a point in time.
  *
  * It can represent time values that are at a distance of at most
@@ skipping 25 matching lines @@
   static const int SEP = 9;
   static const int OCT = 10;
   static const int NOV = 11;
   static const int DEC = 12;
 
   /**
    * Constructs a [Date] instance based on the individual parts. The date is
    * in the local time zone if [isUtc] is false.
    *
    * [month] and [day] are one-based. For example
-   * [:new Date(1938, 1, 10)] represents the 10th of January 1938.
+   * [:new Date(1938, month: 1, day: 10)] represents the 10th of January 1938.
    */
   factory Date(int year,

[Lasse Reichstein Nielsen, 2012/10/09 12:35:00]

Man, you just hit on our bad consciences there.
We really, really should modify the Date constructors to something useful.

Users will need a version that allows positional parameters too. I'm more
inclined to make Date that constructor, and then possibly have another (by some
name) that allows named parameters. A plain usecase is "new Date(2012,10,05)" or
"new Date(2012,10,05,14,33)". That should still be possible.

I'll loop in Florian who did the Date class.

[Lasse Reichstein Nielsen, 2012/10/09 12:50:40]

Using optional positional parameters will make isUtc hard to use. I talked to
Florian about this, and we agree that the best solution is to have two
constructors:
 Date(int year, [int month = 1, ... ])
and
 Date.utc(int year, [int month ...])

[regis, 2012/10/11 01:33:56]

Done.

[regis, 2012/10/11 01:33:56]

Done.

-               [int month = 1,
-                int day = 1,
-                int hour = 0,
-                int minute = 0,
-                int second = 0,
-                int millisecond = 0,
-                bool isUtc = false]) {
-    return new DateImplementation(year, month, day,
-                                  hour, minute, second,
-                                  millisecond, isUtc);
+               {int month: 1,
+                int day: 1,
+                int hour: 0,
+                int minute: 0,
+                int second: 0,
+                int millisecond: 0,
+                bool isUtc: false}) {
+    return new DateImplementation(year, month: month, day: day,

[Lasse Reichstein Nielsen, 2012/10/09 12:35:00]

Modify to match requested change in DateImplementation.

[regis, 2012/10/11 01:33:56]

Done.

+                                  hour: hour, minute: minute, second: second,
+                                  millisecond: millisecond, isUtc: isUtc);
   }
 
   /**
    * Constructs a new [Date] instance with current date time value in the
    * local time zone.
    */
   factory Date.now() => new DateImplementation.now();
 
   /**
    * Constructs a new [Date] instance based on [formattedString].
    */
   factory Date.fromString(String formattedString)
       => new DateImplementation.fromString(formattedString);
 
   /**
    * Constructs a new [Date] instance with the given [millisecondsSinceEpoch].
    * If [isUtc] is false then the date is in the local time zone.
    *
    * The constructed [Date] represents
    * 1970-01-01T00:00:00Z + [millisecondsSinceEpoch]ms in the given
    * time zone (local or UTC).
    */
   // TODO(floitsch): the spec allows default values in interfaces, but our
   // tools don't yet. Eventually we want to have default values here.
   // TODO(lrn): Have two constructors instead of taking an optional bool.
   factory Date.fromMillisecondsSinceEpoch(int millisecondsSinceEpoch,
-                                          [bool isUtc = false]) {
+                                          {bool isUtc: false}) {
     return new DateImplementation.fromMillisecondsSinceEpoch(
         millisecondsSinceEpoch, isUtc);
   }
 
   /**
    * Returns true if [this] occurs at the same time as [other]. The
    * comparison is independent of whether the time is utc or in the local
    * time zone.
    */
   bool operator ==(Date other);
@@ skipping 120 matching lines @@
   /**
    * Returns a new [Date] with the [duration] subtracted from this instance.
    */
   Date subtract(Duration duration);
 
   /**
    * Returns a [Duration] with the difference of [:this:] and [other].
    */
   Duration difference(Date other);
 }