Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1108993006: Make SelectorChecker::tagMatches internal to the SelectorChecker (Closed)

Created:
5 years, 7 months ago by esprehn
Modified:
5 years, 7 months ago
Reviewers:
Timothy Loh, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make SelectorChecker::tagMatches internal to the SelectorChecker SelectorQuery doesn't really want this function since it handles namespaces and querySelector explicitly doesn't deal with namespaces. Instead we can use a simpler check in SelectorQuery and move this function into SelectorChecker.cpp R=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M Source/core/css/SelectorChecker.h View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108993006/1
5 years, 7 months ago (2015-04-29 22:58:50 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-30 01:25:51 UTC) #5
Timothy Loh
lgtm
5 years, 7 months ago (2015-04-30 05:43:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108993006/1
5 years, 7 months ago (2015-04-30 05:53:07 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 05:53:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194702

Powered by Google App Engine
This is Rietveld 408576698