Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1108973005: Merge to XFA: Pin V8 version until initialization issue in b584bab resolved. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Pin V8 version until initialization issue in b584bab resolved. Also make a Handle => Local change for XFA required at https://chromium.googlesource.com/v8/v8.git/+/202a97c88eb6807915135a1e6be9aa921cd8efac to fix compile. Original Review URL https://codereview.chromium.org/1108913004/ TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/551a0fd73570a0292e7b017f764b70c4afde873a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxjse/src/value.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 7 months ago (2015-04-28 21:31:06 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 551a0fd73570a0292e7b017f764b70c4afde873a (presubmit successful).
5 years, 7 months ago (2015-04-28 21:31:25 UTC) #2
Lei Zhang
5 years, 7 months ago (2015-04-28 21:31:50 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698