Conv CHECK->DCHECK in CloseHandle (top crasher & data enough to debug)

base/win/scoped_handle.cc

Index: base/win/scoped_handle.cc
diff --git a/base/win/scoped_handle.cc b/base/win/scoped_handle.cc
index 33a8aa5c743b7b27eab6349fa1f0ee953dca6909..e72b34b765a5e2a3ad29b210f873e6d34bc83696 100644
--- a/base/win/scoped_handle.cc
+++ b/base/win/scoped_handle.cc
@@ -40,8 +40,9 @@ typedef base::internal::LockImpl NativeLock;
 base::LazyInstance<NativeLock>::Leaky g_lock = LAZY_INSTANCE_INITIALIZER;
 
 bool CloseHandleWrapper(HANDLE handle) {
-  if (!::CloseHandle(handle))
-    CHECK(false);
+  if (!::CloseHandle(handle)) {
+    DCHECK(false);

[grt (UTC plus 2), 2015/04/28 01:54:03]

return false in this case. how about:
  if (::CloseHandle(handle))
    return true;
  NOTREACHED():
  return false;
to avoid extra braces.

[Shrikant Kelkar, 2015/04/28 17:59:10]

Done.

+  }
   return true;
 }