Uncomment missing GN resource dependencies in remoting.

Uncomment missing GN resource dependencies in remoting.

Without these, a GN clobber build fails, and we get warnings
during the non-compile builds.

R=garykac@chromium.org
BUG=

Committed: https://crrev.com/156e80e73ce6219e3d386b354de44cf8c1b08bc0
Cr-Commit-Position: refs/heads/master@{#327165}

[Dirk Pranke, 2015-04-27 22:02:54]

I don't know why these were commented out in the first place, so this change
makes me a bit nervous; it it okay?

[garykac, 2015-04-27 22:10:40]

lgtm to unbreak the build, but...

These locales are not part of the GYP build and they result in a runtime error
when the JS webapp tries to load the non-existent locales (esp. fake-bidi).

Why are they needed? Remoting doesn't use (or localize) these languages.

[Dirk Pranke, 2015-04-27 22:22:24]

On 2015/04/27 22:10:40, garykac wrote:
> lgtm to unbreak the build, but...
> 
> These locales are not part of the GYP build and they result in a runtime error
> when the JS webapp tries to load the non-existent locales (esp. fake-bidi).
> 
> Why are they needed? Remoting doesn't use (or localize) these languages.

If I understand how things work correctly, these files are all mentioned in
remoting/resources/remoting_strings.grd as being expected output files, and so
grit generates them.

GN gets unhappy if the list of files you told it to expect doesn't actually
match the list that we do get, which is why we get the warnings.

I think GN also sets up Ninja so that things that depend on remoting_strings
explicitly depend on the list of files, so when the actual/expected output
happens, ninja gets confused about the dependencies and refuses to start a
build. I think we're not seeing this on the normal builds because we were
generating these files at one point and so some old files might still be around.

So, perhaps an alternative is to delete the entries from the .grd ?

[garykac, 2015-04-27 22:34:57]

On 2015/04/27 22:22:24, Dirk Pranke wrote:
> On 2015/04/27 22:10:40, garykac wrote:
> > lgtm to unbreak the build, but...
> > 
> > These locales are not part of the GYP build and they result in a runtime
error
> > when the JS webapp tries to load the non-existent locales (esp. fake-bidi).
> > 
> > Why are they needed? Remoting doesn't use (or localize) these languages.
> 
> If I understand how things work correctly, these files are all mentioned in
> remoting/resources/remoting_strings.grd as being expected output files, and so
> grit generates them.
> 
> GN gets unhappy if the list of files you told it to expect doesn't actually
> match the list that we do get, which is why we get the warnings.
> 
> I think GN also sets up Ninja so that things that depend on remoting_strings
> explicitly depend on the list of files, so when the actual/expected output
> happens, ninja gets confused about the dependencies and refuses to start a
> build. I think we're not seeing this on the normal builds because we were
> generating these files at one point and so some old files might still be
around.
> 
> So, perhaps an alternative is to delete the entries from the .grd ?

Ah. Those were added to fix build problems in CrOS, but the other builds (and
gyp targets) were not updated at that time.

Land this change and I'll work on fixing the other builds to properly handle the
new locales.

Thanks!

[Dirk Pranke, 2015-04-27 22:37:54]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-04-27 22:38:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108953002/1

[commit-bot: I haz the power, 2015-04-27 22:57:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-27 22:58:59]

Patchset 1 (id:??) landed as
https://crrev.com/156e80e73ce6219e3d386b354de44cf8c1b08bc0
Cr-Commit-Position: refs/heads/master@{#327165}