Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1108913006: [chrome/browser/android] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/android module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/778f8abf71081a44194ec131c0874f5a96dde801 Cr-Commit-Position: refs/heads/master@{#327511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/android/logo_service.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/signin/signin_manager_android.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Pranay
PTAL
5 years, 7 months ago (2015-04-29 05:11:59 UTC) #2
Ted C
lgtm
5 years, 7 months ago (2015-04-29 15:18:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108913006/1
5 years, 7 months ago (2015-04-29 16:28:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 16:54:00 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 16:54:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/778f8abf71081a44194ec131c0874f5a96dde801
Cr-Commit-Position: refs/heads/master@{#327511}

Powered by Google App Engine
This is Rietveld 408576698