Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1108903003: Add back interface checking over XPathExpression interface. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add back interface checking over XPathExpression interface. Mistakenly removed by r194504, re-add. R=haraken BUG=481813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/xml/XPathExpression.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. (Conflict resolution on rebase of old CL gone wrong :( )
5 years, 7 months ago (2015-04-28 09:01:40 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-28 09:39:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108903003/1
5 years, 7 months ago (2015-04-28 09:40:30 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 10:13:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194588

Powered by Google App Engine
This is Rietveld 408576698