core/src/fpdfdoc/doc_form.cpp - Issue 1108903002: Merge to XFA: Reduce usage of operator LPCWSTR from CFX_WideString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/doc_form.cpp

Issue 1108903002: Merge to XFA: Reduce usage of operator LPCWSTR from CFX_WideString(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfdoc/doc_form.cpp

diff --git a/core/src/fpdfdoc/doc_form.cpp b/core/src/fpdfdoc/doc_form.cpp

index d8ca525f0a09e9722f7eee4c7580560a5506f2e9..bb2c3a130160e8c9fd4a10251383085aa9787a62 100644

--- a/core/src/fpdfdoc/doc_form.cpp

+++ b/core/src/fpdfdoc/doc_form.cpp

@@ -34,7 +34,7 @@ class _CFieldNameExtractor

public:

_CFieldNameExtractor(const CFX_WideString& full_name)

{

- m_pStart = full_name;

+ m_pStart = full_name.c_str();

m_pEnd = m_pStart + full_name.GetLength();

m_pCur = m_pStart;

}

@@ -736,7 +736,8 @@ int CPDF_InterForm::CompareFieldName(const CFX_ByteString& name1, const CFX_Byte

}

int CPDF_InterForm::CompareFieldName(const CFX_WideString& name1, const CFX_WideString& name2)

{

- FX_LPCWSTR ptr1 = name1, ptr2 = name2;

+ FX_LPCWSTR ptr1 = name1.c_str();

+ FX_LPCWSTR ptr2 = name2.c_str();

if (name1.GetLength() != name2.GetLength()) {

int i = 0;

while (ptr1[i] == ptr2[i]) {

« no previous file with comments | « core/src/fpdfdoc/doc_basic.cpp ('k') | core/src/fpdfdoc/doc_formfield.cpp » ('j') | no next file with comments »