Merge to XFA: Reduce usage of operator LPCWSTR from CFX_WideString().

fpdfsdk/src/javascript/app.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 411 matching lines @@
                                 swTitle = params[i].ToCFXWideString();
                 }
         }
 
 
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
         pRuntime->BeginBlock();
-        vRet = MsgBox(pRuntime->GetReaderApp(), JSGetPageView(cc),swMsg,swTitle,iType,iIcon);
+        vRet = MsgBox(pRuntime->GetReaderApp(), JSGetPageView(cc), swMsg.c_str(), swTitle.c_str(), iType, iIcon);
         pRuntime->EndBlock();
 
         return TRUE;
 }
 
 
 FX_BOOL app::beep(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         if (params.size() == 1)
         {
@@ skipping 18 matching lines @@
         return FALSE;
 }
 
 FX_BOOL app::fs(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         return FALSE;
 }
 
 FX_BOOL app::setInterval(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
+        CJS_Context* pContext = (CJS_Context*)cc;
         if (params.size() > 2 || params.size() == 0)
         {
-                sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
-        CJS_Context* pContext = (CJS_Context*)cc;
-        ASSERT(pContext != NULL);
-        CJS_Runtime* pRuntime = pContext->GetJSRuntime();
-        ASSERT(pRuntime != NULL);
-
-        CFX_WideString script = params.size() > 0 ?  (FX_LPCWSTR)(params[0].ToCFXWideString()) : L"";
+        CFX_WideString script = params.size() > 0 ?  params[0].ToCFXWideString() : L"";
         if (script.IsEmpty())
         {
-                sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSAFNUMBER_KEYSTROKE);
+                sError = JSGetStringFromID(pContext, IDS_STRING_JSAFNUMBER_KEYSTROKE);
                 return TRUE;
         }
 
+        CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         FX_DWORD dwInterval = params.size() > 1 ? params[1].ToInt() : 1000;
 
         CPDFDoc_Environment* pApp = pRuntime->GetReaderApp();
         ASSERT(pApp);
         CJS_Timer* pTimer = new CJS_Timer(this, pApp);
         m_aTimer.Add(pTimer);
 
         pTimer->SetType(0);
         pTimer->SetRuntime(pRuntime);
         pTimer->SetJScript(script);
@@ skipping 22 matching lines @@
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         CJS_Context* pContext = (CJS_Context*)cc;
         ASSERT(pContext != NULL);
         CJS_Runtime* pRuntime = pContext->GetJSRuntime();
         ASSERT(pRuntime != NULL);
 
-        CFX_WideString script = params.size() > 0 ?  (FX_LPCWSTR)(params[0].ToCFXWideString()) : L"";
+        CFX_WideString script = params.size() > 0 ? params[0].ToCFXWideString() : L"";
         if (script.IsEmpty())
         {
                 sError = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSAFNUMBER_KEYSTROKE);
                 return TRUE;
         }
 
         FX_DWORD dwTimeOut = params.size() > 1 ? params[1].ToInt() : 1000;
 
         CPDFDoc_Environment* pApp = pRuntime->GetReaderApp();
         ASSERT(pApp);
@@ skipping 367 matching lines @@
 
         CPDFDoc_Environment* pApp = pContext->GetReaderApp();
         ASSERT(pApp != NULL);
 
         const int MAX_INPUT_BYTES = 2048;
         char* pBuff = new char[MAX_INPUT_BYTES + 2];
         if (!pBuff)
                 return FALSE;
 
         memset(pBuff, 0, MAX_INPUT_BYTES + 2);
-        int nLengthBytes = pApp->JS_appResponse(swQuestion, swTitle, swDefault, swLabel, bPassWord, pBuff, MAX_INPUT_BYTES);
+        int nLengthBytes = pApp->JS_appResponse(swQuestion.c_str(), swTitle.c_str(), swDefault.c_str(),
+                                            swLabel.c_str(), bPassWord, pBuff, MAX_INPUT_BYTES);
         if (nLengthBytes <= 0)
         {
                 vRet.SetNull();
                 delete[] pBuff;
                 return FALSE;
         }
         if (nLengthBytes > MAX_INPUT_BYTES)
                 nLengthBytes = MAX_INPUT_BYTES;
 
-        vRet = CFX_WideString::FromUTF16LE((unsigned short*)pBuff, nLengthBytes / sizeof(unsigned short));
+        vRet = CFX_WideString::FromUTF16LE((unsigned short*)pBuff, nLengthBytes / sizeof(unsigned short)).c_str();
         delete[] pBuff;
         return TRUE;
 }
 
 FX_BOOL app::media(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError)
 {
         return FALSE;
 }
 
 FX_BOOL app::execDialog(IFXJS_Context* cc, const CJS_Parameters& params, CJS_Value& vRet, CFX_WideString& sError)
 {
         return TRUE;
 }