Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: ui/events/keycodes/dom4/keycode_converter_data.h

Issue 1108893002: Revise DOM Level 3 US Layout maps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments (wez@) Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/events/keycodes/dom_us_layout_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/keycodes/dom4/keycode_converter_data.h
diff --git a/ui/events/keycodes/dom4/keycode_converter_data.h b/ui/events/keycodes/dom4/keycode_converter_data.h
index 2f7712ed67b8d73cb2e0a01c599cb1b3bd0932af..3b99875a7233ea5a3c1885de36d1a0ba03f846bf 100644
--- a/ui/events/keycodes/dom4/keycode_converter_data.h
+++ b/ui/events/keycodes/dom4/keycode_converter_data.h
@@ -117,10 +117,12 @@ USB_KEYMAP_DECLARATION {
USB_KEYMAP(0x070031, 0x0033, 0x002b, 0x002a, "Backslash", BACKSLASH), // \|
// USB#070032 never appears on keyboards that have USB#070031.
// Platforms use the same scancode as for the two keys.
+ // Hence this code can only be generated synthetically
+ // (e.g. in a DOM Level 3 KeyboardEvent).
// The keycap varies on international keyboards:
// Dan: '* Dutch: <> Ger: #' UK: #~
// TODO(garykac): Verify Mac intl keyboard.
- //USB_KEYMAP(0x070032, 0x0033, 0x002b, 0x002a, "IntlHash", INTL_HASH),
+ USB_KEYMAP(0x070032, 0x0000, 0x0000, 0xffff, "IntlHash", INTL_HASH),
Wez 2015/05/05 00:16:00 Ick... I forgot that the platforms are munging the
kpschoedel 2015/05/05 18:47:02 Done for DomCodeToNativeKeycode() just by calling
USB_KEYMAP(0x070033, 0x002f, 0x0027, 0x0029, "Semicolon", SEMICOLON), // ;:
USB_KEYMAP(0x070034, 0x0030, 0x0028, 0x0027, "Quote", QUOTE), // '"
USB_KEYMAP(0x070035, 0x0031, 0x0029, 0x0032, "Backquote", BACKQUOTE), // `~
« no previous file with comments | « no previous file | ui/events/keycodes/dom_us_layout_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698