Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1108833003: Replacing v8::Handle<T> with v8::Local<T> (Closed)

Created:
5 years, 7 months ago by ashish1.a
Modified:
5 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, falken, blink-reviews-dom_chromium.org, dglazkov+blink, kinuko+worker_chromium.org, horo+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replacing v8::Handle<T> with v8::Local<T> v8::Handle<T> is just an alias of v8::Local<T> so, replacing v8::Handle with v8::Local in Source/core/* BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M Source/core/dom/DOMArrayBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMArrayBuffer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/DOMDataView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMDataView.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/MessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MessageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMarqueeElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageData.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ashish1.a
Please review the changes. Thanks Ashish
5 years, 7 months ago (2015-04-29 08:30:29 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-29 11:37:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108833003/1
5 years, 7 months ago (2015-04-30 04:04:54 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 05:33:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194700

Powered by Google App Engine
This is Rietveld 408576698