Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: components/favicon/core/large_icon_service.cc

Issue 1108833002: [Local NTP] Fix chrome://large-icon fallback when no favicon is found. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/large_icon_service.cc
diff --git a/components/favicon/core/large_icon_service.cc b/components/favicon/core/large_icon_service.cc
index 702761c82d8adc1a3510a8deb612b157f406dc93..499c42ba9b3e218a4ac5803011f2108262b28cca 100644
--- a/components/favicon/core/large_icon_service.cc
+++ b/components/favicon/core/large_icon_service.cc
@@ -47,6 +47,7 @@ void LargeIconService::RunLargeIconCallback(
// default |fallback_icon_style|.
favicon_base::LargeIconResult result;
if (!bitmap_result.is_valid()) {
+ result.fallback_icon_style.reset(new favicon_base::FallbackIconStyle());
pkotwicz 2015/04/27 17:49:02 Sorry that I missed this. How about adding two new
huangs 2015/04/27 18:16:04 Done.
callback.Run(result);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698