[Local NTP] Fix chrome://large-icon fallback when no favicon is found.

[Local NTP] Fix chrome://large-icon fallback when no favicon is found.

For chrome://large-icon, if no large icon is found then we get the small
favicon to extract the dominant color for fallback background. If the
favicon is missing we're supposed to have a gray background. This behavior
was broken and this CL fixes it.

BUG=467712
Committed: https://crrev.com/5adfb2a5905c9bb71978f45896f39a982ebcddbc
Cr-Commit-Position: refs/heads/master@{#327119}

[huangs, 2015-04-27 15:38:39]

huangs@chromium.org changed reviewers:
+ beaudoin@chromium.org

[huangs, 2015-04-27 15:38:40]

PTAL.

[beaudoin, 2015-04-27 15:39:31]

LGTM

[huangs, 2015-04-27 15:39:53]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2015-04-27 15:39:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108833002/1

[commit-bot: I haz the power, 2015-04-27 15:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 15:45:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[huangs, 2015-04-27 17:00:16]

OWNER review to pkotwicz@, PTAL.

[huangs, 2015-04-27 17:00:25]

huangs@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[huangs, 2015-04-27 17:00:26]

OWNER review to pkotwicz@, PTAL.

[pkotwicz, 2015-04-27 17:49:02]

https://codereview.chromium.org/1108833002/diff/1/components/favicon/core/lar...
File components/favicon/core/large_icon_service.cc (right):

https://codereview.chromium.org/1108833002/diff/1/components/favicon/core/lar...
components/favicon/core/large_icon_service.cc:50:
result.fallback_icon_style.reset(new favicon_base::FallbackIconStyle());
Sorry that I missed this. How about adding two new constructors for
LargeIconResult, one which takes a FallbackIconStyle and another which takes in
FaviconRawBitmapResult and removing the default constructor?

[huangs, 2015-04-27 18:16:05]

Updated, PTAL.

https://codereview.chromium.org/1108833002/diff/1/components/favicon/core/lar...
File components/favicon/core/large_icon_service.cc (right):

https://codereview.chromium.org/1108833002/diff/1/components/favicon/core/lar...
components/favicon/core/large_icon_service.cc:50:
result.fallback_icon_style.reset(new favicon_base::FallbackIconStyle());
On 2015/04/27 17:49:02, pkotwicz wrote:
> Sorry that I missed this. How about adding two new constructors for
> LargeIconResult, one which takes a FallbackIconStyle and another which takes
in
> FaviconRawBitmapResult and removing the default constructor?

Done.

[pkotwicz, 2015-04-27 18:35:48]

lgtm

[huangs, 2015-04-27 19:28:11]

The CQ bit was checked by huangs@chromium.org

[huangs, 2015-04-27 19:28:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
beaudoin@chromium.org
Link to the patchset: https://codereview.chromium.org/1108833002/#ps20001
(title: "Refactoring constructors.")

[huangs, 2015-04-27 19:29:07]

Thanks. Committing!

[commit-bot: I haz the power, 2015-04-27 19:29:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108833002/20001

[commit-bot: I haz the power, 2015-04-27 21:14:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-27 21:15:17]

Patchset 2 (id:??) landed as
https://crrev.com/5adfb2a5905c9bb71978f45896f39a982ebcddbc
Cr-Commit-Position: refs/heads/master@{#327119}