Add CookieStoreConfig to unify API for in-memory and persistent CookieStore Creation.

Add CookieStoreConfig to unify API for in-memory and persistent CookieStore Creation.

This is part of relanding https://chromiumcodereview.appspot.com/12546016

Unifying the Cookiecreation interface makes the cookie store creation more
consistent. Having a config struct also enables the next refactor where we move
the cookie store creation enitrely into the content layer (the embedder will only
responsible for providing the correct configuration).

This also changes the lifetime of CookieCryptoDelegate so one object can be
shared amongst multiple cookie stores. Allows for easier lifetime semantics in
the CookieStoreConfig and also is slightly less wasteful of memory.

TBR=jam
BUG=159193
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244371

[awong, 2014-01-03 02:47:09]

FYI, I'm changing the lifetime of the CookieCryptoDelegate to be the same as the
normal CookieMonsterDelegate. This allows me to make a more uniform API for
creating cookie stores and I don't see any particular reason we really need to
have an ownership transfer semantic here.

[commit-bot: I haz the power, 2014-01-06 19:38:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajwong@chromium.org/110883017/860001

[commit-bot: I haz the power, 2014-01-06 20:08:54]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-06 21:06:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajwong@chromium.org/110883017/970004

[commit-bot: I haz the power, 2014-01-06 21:43:46]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-07 20:37:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajwong@chromium.org/110883017/1240001

[commit-bot: I haz the power, 2014-01-07 22:35:16]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[awong, 2014-01-10 03:57:39]

Hi Brian,

I'm changing the lifetime of CookieCryptoDelegate. The reason for this is that
the ownership transfer semantics for CookieCryptoDelegate makes it really hard
to generalize the cookie store setup per profile.

Using a LazyInstance is suboptimal, but it gets me past this hurdle which is
block a much larger CL that simplifies the way cookies stores are created.

Unless you have a strenuous objection to this, I'd like to commit it.

-Albert

[erikwright (departed), 2014-01-10 21:23:15]

Lifetime changes for crypto delegate LGTM.

[awong, 2014-01-10 21:25:14]

On 2014/01/10 21:23:15, erikwright wrote:
> Lifetime changes for crypto delegate LGTM.

Thanks Erik!

All other changes are relands of the previous CL so submitting with TBR=jam on
them.

[commit-bot: I haz the power, 2014-01-10 21:25:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajwong@chromium.org/110883017/1750001

[commit-bot: I haz the power, 2014-01-10 23:00:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajwong@chromium.org/110883017/1750001

[commit-bot: I haz the power, 2014-01-11 22:39:42]

Change committed as 244371