Issue 110883004: Avoid windows presubmit hang in gclient tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110883004: Avoid windows presubmit hang in gclient tests. (Closed)

Created:
7 years ago by Daniel Bratell

Modified:
7 years ago

Reviewers:
iannucci, Isaac (away), M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Avoid windows presubmit hang in gclient tests. If os.kill(os.getpid(), signal.CTRL_C_EVENT) doesn't do what the test author hopes it will do, the test will hang until it has calculated a million out-of-thread/process results. That is approximately an infinite hang. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=240319