Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Issue 1108823003: Revert of Make it possible to hoist the neutering check for TA property accesses (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make it possible to hoist the neutering check for TA property accesses (patchset #1 id:1 of https://codereview.chromium.org/1107993002/) Reason for revert: [Sheriff] Breaks benchmarks: http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/3403 Original issue's description: > Make it possible to hoist the neutering check for TA property accesses > > Also correctly set up the dependency between propoerty and elements > accesses and the checks > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/6a62e321381e1a212983804c4197068e842b240f > Cr-Commit-Position: refs/heads/master@{#28087} TBR=hpayer@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Committed: https://crrev.com/3f27bb218860586859ae7b6bdea75dbbd0a73a1d Cr-Commit-Position: refs/heads/master@{#28088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M src/hydrogen.cc View 2 chunks +6 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Make it possible to hoist the neutering check for TA property accesses
5 years, 8 months ago (2015-04-27 16:56:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108823003/1
5 years, 8 months ago (2015-04-27 16:56:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 16:56:36 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 16:56:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f27bb218860586859ae7b6bdea75dbbd0a73a1d
Cr-Commit-Position: refs/heads/master@{#28088}

Powered by Google App Engine
This is Rietveld 408576698